-
Notifications
You must be signed in to change notification settings - Fork 1.7k
[AI] API docs for URLContext #15341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AI] API docs for URLContext #15341
Conversation
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. |
Generated by 🚫 Danger |
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request improves the API documentation for URLContext
and related types. The changes generally make the documentation clearer and more descriptive. I've found a couple of issues in the updated comments: one seems to be a copy-paste error, and another refers to a non-existent type. Please see my detailed comments for suggestions on how to fix them. Otherwise, the documentation improvements look great.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request provides good improvements to the API documentation for URLContext
and related types. The changes make the documentation clearer and more consistent. I have one minor suggestion to further improve documentation linking.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request focuses on improving the API documentation for URLContext
and related components. The changes significantly enhance clarity and consistency across the documentation for GenerateContentResponse
, Tool
, URLContextMetadata
, and URLMetadata
. The updated comments are more descriptive, user-friendly, and fix a minor typo. Overall, this is a solid set of documentation improvements with no issues found.
Merging here. Additional comments welcome and will be addressed in a subsequent PR. |
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Inspired by firebase/firebase-js-sdk#9254 and (internal) go/alf-urlcontext-refdocs